[webkit-reviews] review granted: [Bug 206157] [JSC] Consistently use "var" in builtin JS : [Attachment 387494] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 206157: [JSC] Consistently use "var" in builtin JS
https://bugs.webkit.org/show_bug.cgi?id=206157

Attachment 387494: Patch

https://bugs.webkit.org/attachment.cgi?id=387494&action=review




--- Comment #5 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 387494
  --> https://bugs.webkit.org/attachment.cgi?id=387494
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387494&action=review

r=me if EWS bots are green.  Please undo the changes in the comments.

> Source/JavaScriptCore/builtins/RegExpPrototype.js:495
> +    // 6. If flags contains "u", var unicodeMatching be true.
> +    // 7. Else, var unicodeMatching be false.

I think you should undo these.	The use of "let" here is in the English
context, not the JS context.  Also, this is a mirror of the text in the spec.

> Source/JavaScriptCore/builtins/RegExpPrototype.js:498
> +    // 8. If flags contains "y", var newFlags be flags.
> +    // 9. Else, var newFlags be the string that is the concatenation of
flags and "y".

Ditto.	Please undo.

> Source/JavaScriptCore/builtins/RegExpPrototype.js:513
> +    // 13. If limit is undefined, var lim be 2^32-1; else var lim be ?
ToUint32(limit).

Ditto.	Undo.

> Source/JavaScriptCore/builtins/RegExpPrototype.js:547
> +	   // c. If z is null, var q be AdvanceStringIndex(S, q,
unicodeMatching).

Ditto.	Undo.

> Source/JavaScriptCore/builtins/RegExpPrototype.js:556
> +	       // iii. If e = p, var q be AdvanceStringIndex(S, q,
unicodeMatching).

Ditto.	Undo.