[webkit-reviews] review granted: [Bug 206141] [WebCore] Reorganize JSType in WebCore to offer more bits to JSC : [Attachment 387464] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 12 11:09:03 PST 2020


Keith Miller <keith_miller at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 206141: [WebCore] Reorganize JSType in WebCore to offer more bits to JSC
https://bugs.webkit.org/show_bug.cgi?id=206141

Attachment 387464: Patch

https://bugs.webkit.org/attachment.cgi?id=387464&action=review




--- Comment #2 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 387464
  --> https://bugs.webkit.org/attachment.cgi?id=387464
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387464&action=review

r=me. We have 128 types these days?!? O.o

> Source/WebCore/bindings/js/JSDOMWrapper.h:32
>  // JSC allows us to extend JSType. If the highest bit is set, we can add any
Object types and they are

Can you fix this comment to match the new rule.


More information about the webkit-reviews mailing list