[webkit-reviews] review granted: [Bug 160934] Support image-set() standard syntax : [Attachment 387319] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Noam Rosenthal <noam at webkit.org>'s
request for review:
Bug 160934: Support image-set() standard syntax
https://bugs.webkit.org/show_bug.cgi?id=160934

Attachment 387319: Patch

https://bugs.webkit.org/attachment.cgi?id=387319&action=review




--- Comment #14 from Dean Jackson <dino at apple.com> ---
Comment on attachment 387319
  --> https://bugs.webkit.org/attachment.cgi?id=387319
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387319&action=review

> Source/WebCore/ChangeLog:3
> +	   Support image-set() standard syntax

I think this bug should be named Support images URLs without the url() syntax
in image-set.

And maybe we should open another bug for the missing dpi identifier?

> LayoutTests/ChangeLog:28
> +2020-01-09  Noam Rosenthal  <noam at webkit.org>
> +
> +	   Support image-set() standard syntax
> +	   https://bugs.webkit.org/show_bug.cgi?id=160934
> +	   <rdar://problem/27891501>
> +
> +	   Reviewed by Simon Fraser.
> +
> +
> +	   * fast/hidpi/image-set-as-background-quotes-expected.html: Added.
> +	   * fast/hidpi/image-set-as-background-quotes.html: Added.
> +		   Ref-test, image with quotes should work the same as image
with url()

Ooops. Duplicated log entry.