[webkit-reviews] review granted: [Bug 206104] Expose frame information on _WKResourceLoadInfo : [Attachment 387398] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 206104: Expose frame information on _WKResourceLoadInfo
https://bugs.webkit.org/show_bug.cgi?id=206104

Attachment 387398: Patch

https://bugs.webkit.org/attachment.cgi?id=387398&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 387398
  --> https://bugs.webkit.org/attachment.cgi?id=387398
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387398&action=review

> Source/WebKit/Shared/API/Cocoa/_WKFrameHandle.mm:93
> +    [coder encodeObject:@([self frameID]) forKey:@"frameID"];

self.frameID ?

> Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:596
> -    if (page)
> -	   loadParameters.pageHasResourceLoadClient =
page->hasResourceLoadClient();
> +    addParametersFromFrame(webFrame->coreFrame(), loadParameters);

I assume it is totally ok that the loadParameters here might get
.isHTTPSUpgradeEnabled set now, when it didn't before?

> Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:662
> +    addParametersFromFrame(&frame, loadParameters);

Same here.