[webkit-reviews] review granted: [Bug 206124] Platform.h is out of control Part 1: Split WTF_CPU_* macro definitions out of Platform.h and into a new CPU.h : [Attachment 387421] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 206124: Platform.h is out of control Part 1: Split WTF_CPU_* macro
definitions out of Platform.h and into a new CPU.h
https://bugs.webkit.org/show_bug.cgi?id=206124

Attachment 387421: Patch

https://bugs.webkit.org/attachment.cgi?id=387421&action=review




--- Comment #2 from Anders Carlsson <andersca at apple.com> ---
Comment on attachment 387421
  --> https://bugs.webkit.org/attachment.cgi?id=387421
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387421&action=review

> Source/WTF/wtf/CPU.h:186
> +// FIXME: WTF_THUMB_ARCH_VERSION seems unusued. Remove.

*unusued*.

> Source/WTF/wtf/Platform.h:81
> +/* FIXME: This should be renamed to WTF_CPU_ARM_IDIV_INSTRUCTIONS and moved
to CPU.h */

Why use C comments here?