[webkit-reviews] review granted: [Bug 206110] Web Inspector: unable to evaluate in the isolated world of content scripts injected by safari app extensions : [Attachment 387400] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 10 17:16:41 PST 2020


Timothy Hatcher <timothy at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 206110: Web Inspector: unable to evaluate in the isolated world of content
scripts injected by safari app extensions
https://bugs.webkit.org/show_bug.cgi?id=206110

Attachment 387400: Patch

https://bugs.webkit.org/attachment.cgi?id=387400&action=review




--- Comment #6 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 387400
  --> https://bugs.webkit.org/attachment.cgi?id=387400
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387400&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:7209
> +	   m_isolatedWorld = DOMWrapperWorld::create(commonVM(),
DOMWrapperWorld::Type::Internal, makeString("Media Controls (", localName(),
')'));

Should you use ")" instead of ')'?


More information about the webkit-reviews mailing list