[webkit-reviews] review granted: [Bug 205161] [GLIB] Add GLib specific API for JSC JSValueRef.h's JSValueMakeFromJSONString and JSValueCreateJSONString methods : [Attachment 385749] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 205161: [GLIB] Add GLib specific API for JSC JSValueRef.h's
JSValueMakeFromJSONString and JSValueCreateJSONString methods
https://bugs.webkit.org/show_bug.cgi?id=205161

Attachment 385749: Patch

https://bugs.webkit.org/attachment.cgi?id=385749&action=review




--- Comment #3 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 385749
  --> https://bugs.webkit.org/attachment.cgi?id=385749
Patch

Patch LGTM. This looks very handy to get data in and out of a JSCContext,
nicer than manually lots of API calls to build complex values. Also if some
JSON comes from somewhere else and is to be loaded into a JSCContext, it
seems much better to have this functionality than loading it as a string
and having to use JSON.parse() later on in the JS side.