[webkit-reviews] review granted: [Bug 205999] [EME][ClearKey] Refactor CDMClearKey::update() : [Attachment 387238] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted  review:
Bug 205999: [EME][ClearKey] Refactor CDMClearKey::update()
https://bugs.webkit.org/show_bug.cgi?id=205999

Attachment 387238: Patch

https://bugs.webkit.org/attachment.cgi?id=387238&action=review




--- Comment #7 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 387238
  --> https://bugs.webkit.org/attachment.cgi?id=387238
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387238&action=review

> Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp:543
> +static String sharedBufferAsHexString(const RefPtr<SharedBuffer>& buf)

The more I look at this, the more I think we should move it to
SharedBuffer::toHexString...

> Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp:573
> +bool operator<(const CDMInstanceClearKey::Key &k1, const
CDMInstanceClearKey::Key &k2)

& next to the type!