[webkit-reviews] review denied: [Bug 205926] [css-grid] Import grid-align-content-distribution tests to WPT folder : [Attachment 387201] Patch

[bugzilla-daemon at webkit.org]

Javier Fernandez <jfernandez at igalia.com> has denied  review:
Bug 205926: [css-grid] Import grid-align-content-distribution tests to WPT
folder
https://bugs.webkit.org/show_bug.cgi?id=205926

Attachment 387201: Patch

https://bugs.webkit.org/attachment.cgi?id=387201&action=review




--- Comment #3 from Javier Fernandez <jfernandez at igalia.com> ---
Comment on attachment 387201
  --> https://bugs.webkit.org/attachment.cgi?id=387201
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387201&action=review

>
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-c
ontent-distribution-expected.txt:52
> +FAIL .grid 1 assert_equals: 

These tests has some cases that fail. We should investigate it before landing.

>
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-c
ontent-distribution-vertical-lr-expected.txt:52
> +FAIL .grid 1 assert_equals: 

Ditto

>
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-c
ontent-distribution-vertical-lr.html:8
> +<link rel="stylesheet" href="/css/support/grid.css">

I think this test needs the alignment.css support file. Perhaps this is the
cause of the failures mentioned before.

>
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-c
ontent-distribution-vertical-rl-expected.txt:52
> +FAIL .grid 1 assert_equals: 

Ditto

>
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-c
ontent-distribution-vertical-rl.html:8
> +<link rel="stylesheet" href="/css/support/grid.css">

Ditto

>
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-c
ontent-distribution.html:8
> +<link rel="stylesheet" href="/css/support/grid.css">

Ditto