[webkit-reviews] review granted: [Bug 206019] Setting currentScale to non-finite values should throw TypeError : [Attachment 387247] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 9 12:40:54 PST 2020


Said Abou-Hallawa <sabouhallawa at apple.com> has granted Sunny He
<sunny_he at apple.com>'s request for review:
Bug 206019: Setting currentScale to non-finite values should throw TypeError
https://bugs.webkit.org/show_bug.cgi?id=206019

Attachment 387247: Patch

https://bugs.webkit.org/attachment.cgi?id=387247&action=review




--- Comment #3 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
Comment on attachment 387247
  --> https://bugs.webkit.org/attachment.cgi?id=387247
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387247&action=review

> Source/WebCore/ChangeLog:6
> +	   Align SVGElement currentScale definition to SVG2 section 5.14.2.

Please add a link to the specs:
https://www.w3.org/TR/SVG2/struct.html#InterfaceSVGSVGElement.

> LayoutTests/svg/dom/set-currentScale-nonfinite.html:15
> +    svgvar.currentScale = 1.0;
> +    shouldBe('svgvar.currentScale', '1.0')

Maybe you need to add semicolon at the end each statement just for consistency.

> LayoutTests/svg/dom/set-currentScale-nonfinite.html:46
> +	   testFailed('set currentScale to Infinity without error')

svgvar.currentScale is set to character 'a' not Infinity.

> LayoutTests/svg/dom/set-currentScale-nonfinite.html:49
> +	       testPassed('set currentScale to Infinity throws TypeError')

Ditto.


More information about the webkit-reviews mailing list