[webkit-reviews] review granted: [Bug 200043] REGRESSION(r185816): In the Hong Kong locale, navigator.language reports it's in the Taiwan locale : [Attachment 387174] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 200043: REGRESSION(r185816): In the Hong Kong locale, navigator.language
reports it's in the Taiwan locale
https://bugs.webkit.org/show_bug.cgi?id=200043

Attachment 387174: Patch

https://bugs.webkit.org/attachment.cgi?id=387174&action=review




--- Comment #21 from Dean Jackson <dino at apple.com> ---
Comment on attachment 387174
  --> https://bugs.webkit.org/attachment.cgi?id=387174
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387174&action=review

>>
LayoutTests/fast/text/international/system-language/navigator-language/navigato
r-language-en-GB.html:4
>> +<script src="../../../../../resources/js-test-pre.js"></script>
> 
> Can all of the tests use js-test.js instead of pre/post? That’s generally
preferred due to simplicity.

Or just write your own small .js file in this directory to expose
shouldBeEqualToString and do the dump as text stuff.