[webkit-reviews] review granted: [Bug 206009] WKAccessibilityWebPageObjectt should use Accessibility::retrieveValueFromMainThread. : [Attachment 387242] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 206009: WKAccessibilityWebPageObjectt should use
Accessibility::retrieveValueFromMainThread.
https://bugs.webkit.org/show_bug.cgi?id=206009

Attachment 387242: Patch

https://bugs.webkit.org/attachment.cgi?id=387242&action=review




--- Comment #5 from Dean Jackson <dino at apple.com> ---
Comment on attachment 387242
  --> https://bugs.webkit.org/attachment.cgi?id=387242
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387242&action=review

Is there any testable behaviour here?

> Source/WebKit/ChangeLog:3
> +	   WKAccessibilityWebPageObjectt should use
Accessibility::retrieveValueFromMainThread.

Typo Objectt

> Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:56
> +#define PROTECTED_SELF protectedSelf =
RetainPtr<WKAccessibilityWebPageObject>(self)

We don't normally do something like this. We just duplicate the code. I don't
really mind though.