[webkit-reviews] review granted: [Bug 206008] [LFC] Rename UsedHorizontal(Vertical)Values to OverrideHorizontal(Vertical)values : [Attachment 387231] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 9 08:15:04 PST 2020


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 206008: [LFC] Rename UsedHorizontal(Vertical)Values to
OverrideHorizontal(Vertical)values
https://bugs.webkit.org/show_bug.cgi?id=206008

Attachment 387231: Patch

https://bugs.webkit.org/attachment.cgi?id=387231&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 387231
  --> https://bugs.webkit.org/attachment.cgi?id=387231
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387231&action=review

> Source/WebCore/ChangeLog:16
> +	   values for the "compute geometry" functions (e.g. computing the
width of a floating box follows
> +	   the same set of steps as computing the width of an inline replaced
box. So whenever we need to
> +	   compute the width of a floating box, we could just call the
computeInlineReplacedWidth() function.
> +	   However their horizontal margin computations are different and since
width and horizontal margins are being computed together,
> +	   we need to make sure that inlineReplacedWidthAndMargin() takes a set
of pre-computed margin values
> +	   and uses them while computing the width value. Same applies to
min/max-width/heigh computations.)

One day you'll put the entire ChangeLog entry inside parentheses.


More information about the webkit-reviews mailing list