[webkit-reviews] review granted: [Bug 204043] [JSC] Introduce JSArrayIterator : [Attachment 387176] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 204043: [JSC] Introduce JSArrayIterator
https://bugs.webkit.org/show_bug.cgi?id=204043

Attachment 387176: Patch

https://bugs.webkit.org/attachment.cgi?id=387176&action=review




--- Comment #30 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 387176
  --> https://bugs.webkit.org/attachment.cgi?id=387176
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387176&action=review

>>> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:3361
>>> +	     if (node->op() == CheckArray &&
node->arrayMode().alreadyChecked(m_graph, node, forNode(node->child1()))) {
>> 
>> What's the purpose of `node->op() == CheckArray`? If we would like to take
the following part in CheckNeutered too, I think we need to put FALLTHROUGH
instead of break in CheckNeutered.
> 
> Whoops, that's leftover from the first iteration of CheckNeutered that didn't
rely on CheckArray doing the array check. Will remove.

OK, make sense.