[webkit-reviews] review denied: [Bug 205967] [Media in GPU process] Extend the GPU process sandbox to allow access to local files when necessary : [Attachment 387155] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 205967: [Media in GPU process] Extend the GPU process sandbox to allow
access to local files when necessary
https://bugs.webkit.org/show_bug.cgi?id=205967

Attachment 387155: Patch

https://bugs.webkit.org/attachment.cgi?id=387155&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 387155
  --> https://bugs.webkit.org/attachment.cgi?id=387155
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387155&action=review

> Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:114
> +std::pair<uint64_t&, uint64_t&>
GPUProcessProxy::useCountsForURL(WebCore::ProcessIdentifier pid, const URL&
url)

This is really icky, returning references to values in a hashMap. It would be
way too easy to write code that stores those references, deletes an entry, then
assigns a value to the reference.

> Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:209
> +    processCount = globalCount = 1;

Like right here; it's very unclear that this is changing values in the hashmap.