[webkit-reviews] review granted: [Bug 205940] Fix testing Makefile to inherit preprocessor definitions : [Attachment 387119] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 8 12:07:20 PST 2020
Mark Lam <mark.lam at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 205940: Fix testing Makefile to inherit preprocessor definitions
https://bugs.webkit.org/show_bug.cgi?id=205940
Attachment 387119: Patch
https://bugs.webkit.org/attachment.cgi?id=387119&action=review
--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 387119
--> https://bugs.webkit.org/attachment.cgi?id=387119
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=387119&action=review
r=me with fix.
> ChangeLog:17
> +2020-01-08 Keith Miller <keith_miller at apple.com>
> +
> + Fix testing Makefile to inherit preprocessor definitions
> + https://bugs.webkit.org/show_bug.cgi?id=205940
> +
> + Reviewed by NOBODY (OOPS!).
> +
> + * Makefile.shared:
Remove dupe ChangeLog.
More information about the webkit-reviews
mailing list