[webkit-reviews] review granted: [Bug 205922] RemoteVideoSample should be able to support canvas video samples : [Attachment 387100] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 205922: RemoteVideoSample should be able to support canvas video samples
https://bugs.webkit.org/show_bug.cgi?id=205922

Attachment 387100: Patch

https://bugs.webkit.org/attachment.cgi?id=387100&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 387100
  --> https://bugs.webkit.org/attachment.cgi?id=387100
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387100&action=review

> Source/WebCore/platform/graphics/RemoteVideoSample.cpp:56
> +    auto ioSurface =  IOSurface::create(size, sRGBColorSpaceRef(),
IOSurface::Format::RGBA);

Minor nit: you might as well move this down a few lines in case
CVPixelBufferLockBaseAddress fails.

> Source/WebCore/platform/graphics/RemoteVideoSample.cpp:109
> +	       RELEASE_LOG_ERROR(Media, "RemoteVideoSample::create:
CVPixelBufferGetIOSurface returned nullptr");

This log message is now incorrect.

>
LayoutTests/http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable-g
puprocess-expected.txt:5
> +Harness Error (TIMEOUT), message = null
> +
> +TIMEOUT Verify MediaRecorder is working in GPUProcess Test timed out

Maybe add a comment to the ChangeLog about why the new test fails?