[webkit-reviews] review granted: [Bug 205905] Reduce binary size by purging C++ type information in Objective-C fields and parameters : [Attachment 387071] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 7 21:44:34 PST 2020


Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 205905: Reduce binary size by purging C++ type information in Objective-C
fields and parameters
https://bugs.webkit.org/show_bug.cgi?id=205905

Attachment 387071: Patch

https://bugs.webkit.org/attachment.cgi?id=387071&action=review




--- Comment #6 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 387071
  --> https://bugs.webkit.org/attachment.cgi?id=387071
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387071&action=review

Nice!!

r=me

> Source/WTF/ChangeLog:8
> +	   Objective-C has reflection mechanism. This means that fields,
methods, and their types

"has reflection" => "has a reflection"

> Source/WTF/ChangeLog:24
> +	       2. T* / T& is in Objective-C fields or paramter types (including
a return type).

paramter => parameter


More information about the webkit-reviews mailing list