[webkit-reviews] review granted: [Bug 204043] [JSC] Introduce JSArrayIterator : [Attachment 387057] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 204043: [JSC] Introduce JSArrayIterator
https://bugs.webkit.org/show_bug.cgi?id=204043

Attachment 387057: Patch

https://bugs.webkit.org/attachment.cgi?id=387057&action=review




--- Comment #24 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 387057
  --> https://bugs.webkit.org/attachment.cgi?id=387057
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387057&action=review

r=me

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1462
> +			   [&] (RegisteredStructure structure) {

WebKit coding style now requires no-space between [] and ().

> Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp:888
> +	   case NewArrayIterator: {
> +	       target = handleInternalFieldClass<JSArrayIterator>(node,
writes);
> +	       break;
> +	   }

Can you add/file FIXME about supporting other types of internal field objects?
(JSGenerator etc.)

> Source/JavaScriptCore/runtime/JSArrayIterator.cpp:68
> +    Base::finishCreation(vm);

We should call Base::finishCreation(vm) first to finish "initializingObject"
phase. (JSCell::finishCreation).