[webkit-reviews] review granted: [Bug 205407] Create a mechanism for 'safe by default' web views : [Attachment 387033] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted
katherine_cheney at apple.com's request for review:
Bug 205407: Create a mechanism for 'safe by default' web views
https://bugs.webkit.org/show_bug.cgi?id=205407

Attachment 387033: Patch

https://bugs.webkit.org/attachment.cgi?id=387033&action=review




--- Comment #18 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 387033
  --> https://bugs.webkit.org/attachment.cgi?id=387033
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387033&action=review

r=me with a few nits

> Source/WebKit/Shared/WebViewCategory.h:30
> +enum WebViewCategory {

This should be enum class WebViewCategory : uint8_t

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:1149
> +static WebKit::WebViewCategory
convertToAPIWebViewCategory(_WKWebViewCategory category)

toWebKitWebViewCategory

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:1163
> +static _WKWebViewCategory
convertFromAPIWebViewCategory(WebKit::WebViewCategory category)

toWKWebViewCategory

> Tools/TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:65
> +    EXPECT_EQ([configuration _webViewCategory],
_WKWebViewCategoryHybridApp);

These can be merged to one test.