[webkit-reviews] review granted: [Bug 205875] run-webkit-tests: clobber-old-results should remove the entire results folder : [Attachment 387032] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 205875: run-webkit-tests: clobber-old-results should remove the entire
results folder
https://bugs.webkit.org/show_bug.cgi?id=205875

Attachment 387032: Patch

https://bugs.webkit.org/attachment.cgi?id=387032&action=review




--- Comment #7 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 387032
  --> https://bugs.webkit.org/attachment.cgi?id=387032
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387032&action=review

Yes, I also don't remember any files or run-webkit-tests modes where we wanted
to keep any files in the results directory between invocations.

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:628
> -	   # Now we test that --clobber-old-results does remove the old entries
and the old retries,
> -	   # and that we don't retry again.
> +	   # Now we test that --clobber-old-results does remove the old entries
and the old retries

Please keep the period at the end of the sentence.