[webkit-reviews] review granted: [Bug 205869] Reformat WebFrameLoaderClient logging : [Attachment 386992] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Keith Rollin
<krollin at apple.com>'s request for review:
Bug 205869: Reformat WebFrameLoaderClient logging
https://bugs.webkit.org/show_bug.cgi?id=205869

Attachment 386992: Patch

https://bugs.webkit.org/attachment.cgi?id=386992&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 386992
  --> https://bugs.webkit.org/attachment.cgi?id=386992
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386992&action=review

r=me

> Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:339
> +	   WEBFRAMELOADERCLIENT_RELEASE_LOG_FAULT(Loading,
"dispatchDidReceiveServerRedirectForProvisionalLoad: Called with no provisional
DocumentLoader (frameState=%i, stateForDebugging=%i)",
m_frame->coreFrame()->loader().state(),
m_frame->coreFrame()->loader().stateMachine().stateForDebugging());

This seems a little wordy, but I can't think of a better naming scheme.