[webkit-reviews] review granted: [Bug 89052] Implement css3-images image-orientation : [Attachment 386994] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 89052: Implement css3-images image-orientation
https://bugs.webkit.org/show_bug.cgi?id=89052

Attachment 386994: Patch

https://bugs.webkit.org/attachment.cgi?id=386994&action=review




--- Comment #51 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 386994
  --> https://bugs.webkit.org/attachment.cgi?id=386994
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386994&action=review

> Source/JavaScriptCore/ChangeLog:8
> +	   * Configurations/FeatureDefines.xcconfig:

You should say what the change is here.

> Source/WTF/ChangeLog:8
> +	   * wtf/FeatureDefines.h:

Ditto.

> Source/WebCore/rendering/style/RenderStyle.h:2112
> +    if (m_rareInheritedData->imageOrientation ==
ImageOrientation::FromImage)

Can this function just return m_rareInheritedData->imageOrientation ?