[webkit-reviews] review granted: [Bug 205840] check-webkit-style: bmalloc doesn't use config.h : [Attachment 386919] PATCH

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 7 09:09:34 PST 2020


Jonathan Bedard <jbedard at apple.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 205840: check-webkit-style: bmalloc doesn't use config.h
https://bugs.webkit.org/show_bug.cgi?id=205840

Attachment 386919: PATCH

https://bugs.webkit.org/attachment.cgi?id=386919&action=review




--- Comment #4 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 386919
  --> https://bugs.webkit.org/attachment.cgi?id=386919
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=386919&action=review

> Tools/Scripts/webkitpy/style/checkers/cpp.py:312
> +	     has_config_header: Whether framework uses config.h or not.

I don't think you mean framework here, I think this should just be 'Whether the
header includes config.h'. bmalloc isn't a framework in the strictest sense, we
could probably use 'project' too, I suppose.


More information about the webkit-reviews mailing list