[webkit-reviews] review granted: [Bug 205849] Improve logging of creating a service worker : [Attachment 386949] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 205849: Improve logging of creating a service worker
https://bugs.webkit.org/show_bug.cgi?id=205849

Attachment 386949: Patch

https://bugs.webkit.org/attachment.cgi?id=386949&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 386949
  --> https://bugs.webkit.org/attachment.cgi?id=386949
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386949&action=review

> Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp:158
> +    RELEASE_LOG(ServiceWorker, "Created service worker %s in process PID
%i", data.serviceWorkerIdentifier.loggingString().utf8().data(),
getCurrentProcessID());

%s -> %{public}s

Note that personally I prefer using data.serviceWorkerIdentifier.toUInt64()
rather than constructing a string. I would actually recommend that instead.