[webkit-reviews] review granted: [Bug 205716] [GTK][WPE] Add API to retrieve and delete surrounding text for input methods : [Attachment 386674] Patch

[bugzilla-daemon at webkit.org]

Zan Dobersek <zan at falconsigh.net> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 205716: [GTK][WPE] Add API to retrieve and delete surrounding text for
input methods
https://bugs.webkit.org/show_bug.cgi?id=205716

Attachment 386674: Patch

https://bugs.webkit.org/attachment.cgi?id=386674&action=review




--- Comment #2 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 386674
  --> https://bugs.webkit.org/attachment.cgi?id=386674
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386674&action=review

> Source/WebKit/UIProcess/API/gtk/WebKitInputMethodContextImplGtk.cpp:32
> +    unsigned surroundingCursorIndex;

Maybe explicitly initialize this to 0.

> Source/WebKit/UIProcess/WebPageProxy.cpp:8213
> +void WebPageProxy::deleteSurrounding(int offset, unsigned characterCount)

Should this be an int64_t, to match the WebPage::deleteSurrounding()?

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:45
> +    unsigned surroundingCursorIndex;

Maybe initialize this too, if needed.