[webkit-reviews] review granted: [Bug 205486] ComplexTextController::offsetForPosition returns a wrong offset for a glyph boundary in a RTL text : [Attachment 386385] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 6 21:04:31 PST 2020
Ross Kirsling <ross.kirsling at sony.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 205486: ComplexTextController::offsetForPosition returns a wrong offset for
a glyph boundary in a RTL text
https://bugs.webkit.org/show_bug.cgi?id=205486
Attachment 386385: Patch
https://bugs.webkit.org/attachment.cgi?id=386385&action=review
--- Comment #19 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 386385
--> https://bugs.webkit.org/attachment.cgi?id=386385
Patch
While this isn't my usual reviewing domain, the change and your explanation are
quite clear, a test is fixed and another added, and EWS is happy, so that makes
me feel pretty good about this patch.
More information about the webkit-reviews
mailing list