[webkit-reviews] review granted: [Bug 205838] Rename start/endPosition to start/endOffset in SelectionRangeData for clarity : [Attachment 386920] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 6 19:39:44 PST 2020


Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 205838: Rename start/endPosition to start/endOffset in SelectionRangeData
for clarity
https://bugs.webkit.org/show_bug.cgi?id=205838

Attachment 386920: Patch

https://bugs.webkit.org/attachment.cgi?id=386920&action=review




--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 386920
  --> https://bugs.webkit.org/attachment.cgi?id=386920
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386920&action=review

> Source/WebCore/rendering/InlineTextBox.cpp:187
> +	   auto startPos = selection.startOffset();
> +	   auto endPos = selection.endOffset();

Let's rename these as well.


More information about the webkit-reviews mailing list