[webkit-reviews] review requested: [Bug 205807] REGRESSION: [ Mac Debug ] inspector/page/setBootstrapScript-main-frame.html is a flaky failure : [Attachment 386906] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 6 15:56:11 PST 2020


Devin Rousso <drousso at apple.com> has asked  for review:
Bug 205807: REGRESSION: [ Mac Debug ]
inspector/page/setBootstrapScript-main-frame.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=205807

Attachment 386906: Patch

https://bugs.webkit.org/attachment.cgi?id=386906&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Created attachment 386906

  --> https://bugs.webkit.org/attachment.cgi?id=386906&action=review

Patch

It took a while (over 10000 iterations), but I was finally able to reproduce
this locally.  I'm not 100% sure whether all of them are actually necessary to
fix this issue, but I do think all of them are necessary overall (e.g. some may
effectively be a drive-by), and since it seems to reproduce so infrequently for
me, I'd rather put the patch up and get it tested/landed than take the (likely
long) time to try to bisect what actually fixed it among these changes.


More information about the webkit-reviews mailing list