[webkit-reviews] review granted: [Bug 205838] Rename start/endPosition to start/endOffset in SelectionRangeData for clarity : [Attachment 386903] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 6 15:47:07 PST 2020


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 205838: Rename start/endPosition to start/endOffset in SelectionRangeData
for clarity
https://bugs.webkit.org/show_bug.cgi?id=205838

Attachment 386903: Patch

https://bugs.webkit.org/attachment.cgi?id=386903&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 386903
  --> https://bugs.webkit.org/attachment.cgi?id=386903
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386903&action=review

> Source/WebCore/ChangeLog:8
> +	   Offset is a more correct term for this variable, as it it just an
unsigned.

it it


More information about the webkit-reviews mailing list