[webkit-reviews] review granted: [Bug 205822] [iOS] Only prewarm fonts with valid font names : [Attachment 386872] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 6 12:13:01 PST 2020


Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 205822: [iOS] Only prewarm fonts with valid font names
https://bugs.webkit.org/show_bug.cgi?id=205822

Attachment 386872: Patch

https://bugs.webkit.org/attachment.cgi?id=386872&action=review




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 386872
  --> https://bugs.webkit.org/attachment.cgi?id=386872
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386872&action=review

r=me, but I wonder if that conditional should also allow MacCatalyst.

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1697
> +#if PLATFORM(MAC)

What about MacCatalyst?


More information about the webkit-reviews mailing list