[webkit-reviews] review granted: [Bug 205572] Web Inspector: Color picker: make it keyboard accessible : [Attachment 386363] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 6 10:56:59 PST 2020
Brian Burg <bburg at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 205572: Web Inspector: Color picker: make it keyboard accessible
https://bugs.webkit.org/show_bug.cgi?id=205572
Attachment 386363: Patch
https://bugs.webkit.org/attachment.cgi?id=386363&action=review
--- Comment #3 from Brian Burg <bburg at apple.com> ---
Comment on attachment 386363
--> https://bugs.webkit.org/attachment.cgi?id=386363
Patch
r=me, with one issue.
Whenever I use arrows, I get the Bonking noise (InspectorFrontendHost.beep()?)
that happens when the default event handler runs. So I think you need to call
.preventDefault() on the event after handling it.
More information about the webkit-reviews
mailing list