[webkit-reviews] review denied: [Bug 205794] Fix non unified build in FIDO Pin.cpp : [Attachment 386832] Patch

[bugzilla-daemon at webkit.org]

Jiewen Tan <jiewen_tan at apple.com> has denied youenn fablet
<youennf at gmail.com>'s request for review:
Bug 205794: Fix non unified build in FIDO Pin.cpp
https://bugs.webkit.org/show_bug.cgi?id=205794

Attachment 386832: Patch

https://bugs.webkit.org/attachment.cgi?id=386832&action=review




--- Comment #3 from Jiewen Tan <jiewen_tan at apple.com> ---
Comment on attachment 386832
  --> https://bugs.webkit.org/attachment.cgi?id=386832
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386832&action=review

Thanks for catching this bug. My bad.

> Source/WebCore/Modules/webauthn/fido/DeviceResponseConverter.cpp:-47
> -constexpr size_t kResponseCodeLength = 1;

I think it is better to name it CtapDeviceResponseCodeLength = 1 in
FidoConstants.h after enum class CtapDeviceResponseCode.