[webkit-reviews] review denied: [Bug 205775] [GTK][WPE] Prepare bots for Flatpak migration : [Attachment 386784] Patch

[bugzilla-daemon at webkit.org]

Carlos Alberto Lopez Perez <clopez at igalia.com> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 205775: [GTK][WPE] Prepare bots for Flatpak migration
https://bugs.webkit.org/show_bug.cgi?id=205775

Attachment 386784: Patch

https://bugs.webkit.org/attachment.cgi?id=386784&action=review




--- Comment #2 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 386784
  --> https://bugs.webkit.org/attachment.cgi?id=386784
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386784&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/steps.py:224
> +def appendCustomEnvironmentVariables(step, platform):
> +    if platform in ('gtk', 'wpe'):
> +	   step.slaveEnvironment['WEBKIT_JHBUILD'] = '1'
> +

Please don't add this environment variable from the buildbot master config.
Each worker defines its own environment variables at startup. This is something
that the admin of the bot does (on a systemd unit file usually)
Before landing this patch you need to talk with the admins of the GTK/EWS bots
to add this environment variable to each of the bots environment.

> Tools/BuildSlaveSupport/ews-build/steps.py:782
> +def appendCustomEnvironmentVariables(step, platform):
> +    if platform in ('gtk', 'wpe'):
> +	   step.slaveEnvironment['WEBKIT_JHBUILD'] = '1'
> +

Ditto

> Tools/BuildSlaveSupport/gtk/buildbot/run:71
> +		WEBKIT_JHBUILD=1 \

Ditto