[webkit-reviews] review denied: [Bug 205776] Enable running a release build with debug ASSERTs. : [Attachment 386798] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 5 23:52:30 PST 2020


Mark Lam <mark.lam at apple.com> has denied Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 205776: Enable running a release build with debug ASSERTs.
https://bugs.webkit.org/show_bug.cgi?id=205776

Attachment 386798: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=386798&action=review




--- Comment #13 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 386798
  --> https://bugs.webkit.org/attachment.cgi?id=386798
proposed patch.

Now that https://bugs.webkit.org/show_bug.cgi?id=205787 will take care of
enabling Debug builds to run fast, we no longer need to try to finagle the code
to enable debug ASSERTs in some components and not others.

I'm going to redo this patch to only be a rename of ASSERT_DISABLED to
ASSERT_ENABLED plus the fixes where tests of NDEBUG should actually be tests of
ASSERT_ENABLED.


More information about the webkit-reviews mailing list