[webkit-reviews] review granted: [Bug 205753] The "ITP Database Backend" flag is not working correctly : [Attachment 386730] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jan 5 14:40:34 PST 2020
Dean Jackson <dino at apple.com> has granted katherine_cheney at apple.com's request
for review:
Bug 205753: The "ITP Database Backend" flag is not working correctly
https://bugs.webkit.org/show_bug.cgi?id=205753
Attachment 386730: Patch
https://bugs.webkit.org/attachment.cgi?id=386730&action=review
--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 386730
--> https://bugs.webkit.org/attachment.cgi?id=386730
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=386730&action=review
> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:402
> + if (!isITPDatabaseEnabledValue)
> + parameters.shouldEnableITPDatabase =
m_defaultPageGroup->preferences().isITPDatabaseEnabled();
> + else
> + parameters.shouldEnableITPDatabase =
isITPDatabaseEnabledValue.boolValue;
I think this conditional should be reversed. i.e. if the value from user prefs
exists, use it, otherwise go to the page group defaults.
More information about the webkit-reviews
mailing list