[webkit-reviews] review granted: [Bug 205759] Further simplify StringBuilder usage by standardizing hex formating to a single hex() function : [Attachment 386771] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 205759: Further simplify StringBuilder usage by standardizing hex formating
to a single hex() function
https://bugs.webkit.org/show_bug.cgi?id=205759

Attachment 386771: Patch

https://bugs.webkit.org/attachment.cgi?id=386771&action=review




--- Comment #9 from Dean Jackson <dino at apple.com> ---
Comment on attachment 386771
  --> https://bugs.webkit.org/attachment.cgi?id=386771
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386771&action=review

> Tools/TestWebKitAPI/Tests/WTF/HexNumber.cpp:34
> +// Not using builder.toString() or builder.toStringPreserveCapacity()
because they all
> +// change internal state of builder.

Why does that matter? You never use the builder again after the expect()
method.