[webkit-reviews] review granted: [Bug 205316] [iOS] Issue mach lookup extension to launch services daemon for Mail : [Attachment 386772] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 4 18:31:43 PST 2020


Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 205316: [iOS] Issue mach lookup extension to launch services daemon for
Mail
https://bugs.webkit.org/show_bug.cgi?id=205316

Attachment 386772: Patch

https://bugs.webkit.org/attachment.cgi?id=386772&action=review




--- Comment #7 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 386772
  --> https://bugs.webkit.org/attachment.cgi?id=386772
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386772&action=review

R=me

> Tools/WebKitTestRunner/TestController.cpp:627
> +	   // Exit if the application bundle identifier has already been set,
since it can only be set once.

Could this just be a RELEASE_ASSERT?


More information about the webkit-reviews mailing list