[webkit-reviews] review granted: [Bug 205749] Crashes under -[WKWebView _addUpdateVisibleContentRectPreCommitHandler]_block_invoke : [Attachment 386714] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 205749: Crashes under -[WKWebView
_addUpdateVisibleContentRectPreCommitHandler]_block_invoke
https://bugs.webkit.org/show_bug.cgi?id=205749

Attachment 386714: Patch

https://bugs.webkit.org/attachment.cgi?id=386714&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 386714
  --> https://bugs.webkit.org/attachment.cgi?id=386714
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386714&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3578
> +    RetainPtr<WKContentView> view = retainPtr(self);
> +    RetainPtr<WKWebView> webView = _webView.get();

Undo this part

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6020
> +    [presentingViewController.transitionCoordinator
animateAlongsideTransition:nil completion:[weakWebView =
WeakObjCPtr<WKWebView>(self.webView), controller =
_presentedFullScreenInputViewController] (id
<UIViewControllerTransitionCoordinatorContext>) {

Can we just copy the weak ptr?

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6041
> +    [[presentedController transitionCoordinator]
animateAlongsideTransition:nil completion:[weakWebView =
WeakObjCPtr<WKWebView>(self.webView), controller = presentedController] (id
<UIViewControllerTransitionCoordinatorContext>) {

Ditto