[webkit-reviews] review granted: [Bug 205740] Update the RemoteMediaPlayerManagerProxy::Load XPC message to provide the updated RemoteMediaPlayerConfiguration to the web process : [Attachment 386701] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Peng Liu
<peng.liu6 at apple.com>'s request for review:
Bug 205740: Update the RemoteMediaPlayerManagerProxy::Load XPC message to
provide the updated RemoteMediaPlayerConfiguration to the web process
https://bugs.webkit.org/show_bug.cgi?id=205740

Attachment 386701: Patch

https://bugs.webkit.org/attachment.cgi?id=386701&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 386701
  --> https://bugs.webkit.org/attachment.cgi?id=386701
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386701&action=review

Thanks!

> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:94
> +    configuration.engineDescription = m_player->engineDescription();
> +    configuration.supportsScanning = m_player->supportsScanning();
> +    configuration.supportsFullscreen = m_player->supportsFullscreen();
> +    configuration.supportsPictureInPicture =
m_player->supportsPictureInPicture();
> +    configuration.supportsAcceleratedRendering =
m_player->supportsAcceleratedRendering();
> +    configuration.canPlayToWirelessPlaybackTarget =
m_player->canPlayToWirelessPlaybackTarget();

Nit: is there any really you can't use getConfiguration()?