[webkit-reviews] review requested: [Bug 205730] [Apple Pay] Provide a better error message when Apple Pay blocks user agent script evaluation : [Attachment 386692] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has asked  for review:
Bug 205730: [Apple Pay] Provide a better error message when Apple Pay blocks
user agent script evaluation
https://bugs.webkit.org/show_bug.cgi?id=205730

Attachment 386692: Patch

https://bugs.webkit.org/attachment.cgi?id=386692&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 386692
  --> https://bugs.webkit.org/attachment.cgi?id=386692
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386692&action=review

> Source/WebKit/WebProcess/ApplePay/WebPaymentCoordinator.cpp:162
> +    return "Unable to run user agent scripts because this document uses
Apple Pay. Apple Pay can be disabled in this web view by injecting a
WKUserScript."_s;

This is confusing.  It seems like it's unable to run scripts because of Apple
Pay, but running scripts can disable Apple Pay.  "user agent scripts" is
unclear.
I think what you're trying to say is that to run scripts using
evaluteJavaScript on pages that try to use Apple Pay, use WKUserScripts to
disable Apple Pay.  Is that correct?