[webkit-reviews] review granted: [Bug 205692] Improve release logging in ServiceWorkerFetchTask : [Attachment 386628] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 3 01:04:43 PST 2020


youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 205692: Improve release logging in ServiceWorkerFetchTask
https://bugs.webkit.org/show_bug.cgi?id=205692

Attachment 386628: Patch

https://bugs.webkit.org/attachment.cgi?id=386628&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 386628
  --> https://bugs.webkit.org/attachment.cgi?id=386628
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386628&action=review

> Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:252
> +	   RELEASE_LOG_IF_ALLOWED("softUpdateIfNeeded: Scheduling soft
update");

Would probably be better added in SWServerRegistration::scheduleSoftUpdate
given scheduleSoftUpdate is called in two places.


More information about the webkit-reviews mailing list