[webkit-reviews] review granted: [Bug 205697] AI rule for PutById can only observe transitions when it watches the condition : [Attachment 386644] patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 205697: AI rule for PutById can only observe transitions when it watches
the condition
https://bugs.webkit.org/show_bug.cgi?id=205697

Attachment 386644: patch

https://bugs.webkit.org/attachment.cgi?id=386644&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 386644
  --> https://bugs.webkit.org/attachment.cgi?id=386644
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386644&action=review

r=me

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:3771
> +	       bool isOK = true;

I recommend using `allGood` instead of `isOK` to align the name to the
constant-folding phase one.