[webkit-reviews] review granted: [Bug 205691] Reformat WebProcess logging : [Attachment 386637] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Keith Rollin <krollin at apple.com>'s
request for review:
Bug 205691: Reformat WebProcess logging
https://bugs.webkit.org/show_bug.cgi?id=205691

Attachment 386637: Patch

https://bugs.webkit.org/attachment.cgi?id=386637&action=review




--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 386637
  --> https://bugs.webkit.org/attachment.cgi?id=386637
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386637&action=review

> Source/WebKit/WebProcess/WebProcess.cpp:171
> +#define RELEASE_LOG_SESSION_ID (m_sessionID.hasValue() ?
m_sessionID->toUInt64() : 0)

m_sessionID.valueOr(0)

> Source/WebKit/WebProcess/WebProcess.h:489
> +    bool isAlwaysOnLoggingAllowed() { return m_sessionID.hasValue() ?
m_sessionID->isAlwaysOnLoggingAllowed() : true; }

m_sessionID ? m_sessionID->isAlwaysOnLoggingAllowed() : true;

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:129
> +#define RELEASE_LOG_SESSION_ID (m_sessionID.hasValue() ?
m_sessionID->toUInt64() : 0)

valueOr()