[webkit-reviews] review granted: [Bug 205693] [LFC][Integration] Fix failing text-indent cases when the IFC root is an anonymous box : [Attachment 386633] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 2 14:58:31 PST 2020


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 205693: [LFC][Integration] Fix failing text-indent cases when the IFC root
is an anonymous box
https://bugs.webkit.org/show_bug.cgi?id=205693

Attachment 386633: Patch

https://bugs.webkit.org/attachment.cgi?id=386633&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 386633
  --> https://bugs.webkit.org/attachment.cgi?id=386633
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386633&action=review

> Source/WebCore/layout/LayoutState.h:83
> +    bool isIntegratedRootBoxFirstChild() const { return
m_layoutTreeContent->isRootFirstChild(); }

Can't this bit (and any other integration hacks) just be in LayoutState like
the viewport size?


More information about the webkit-reviews mailing list