[webkit-reviews] review granted: [Bug 205583] REGRESSION (r253867): Six test262 tests broken : [Attachment 386621] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 205583: REGRESSION (r253867): Six test262 tests broken
https://bugs.webkit.org/show_bug.cgi?id=205583

Attachment 386621: Patch

https://bugs.webkit.org/attachment.cgi?id=386621&action=review




--- Comment #6 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 386621
  --> https://bugs.webkit.org/attachment.cgi?id=386621
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386621&action=review

r=me

> Source/JavaScriptCore/ChangeLog:12
> +	   If a function has empty name, a bound function should have "bound "
name.
> +	   But Intl prototypes' bound functions are exceptions: these
JSBoundFunctions have empty name.
> +	   In this patch, we pass `nullptr` for the JSBoundFunction::create's
nameMayBeNull parameter of Intl prototypes' bound functions,
> +	   to generate empty string name for these bound functions instead of
"bound ".
> +	   This fixes test262 failures.

nit: Would be nice to quote the urls to the relevant spec here if you have
them.