[webkit-reviews] review requested: [Bug 205544] Replace uses of Box<Identifier> with a new CacheableIdentifier class. : [Attachment 386616] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 2 12:09:42 PST 2020


Mark Lam <mark.lam at apple.com> has asked  for review:
Bug 205544: Replace uses of Box<Identifier> with a new CacheableIdentifier
class.
https://bugs.webkit.org/show_bug.cgi?id=205544

Attachment 386616: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=386616&action=review




--- Comment #15 from Mark Lam <mark.lam at apple.com> ---
Created attachment 386616

  --> https://bugs.webkit.org/attachment.cgi?id=386616&action=review

proposed patch.

Uploading new patch with all the feedback applied for EWS testing and for
commenting.  Still need to think through Yusuke's questions about potential GC
correctness issues.


More information about the webkit-reviews mailing list