[webkit-reviews] review granted: [Bug 199225] [Payment Request] Perform payment method data IDL conversion in the PaymentRequest constructor : [Attachment 386586] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 199225: [Payment Request] Perform payment method data IDL conversion in the
PaymentRequest constructor
https://bugs.webkit.org/show_bug.cgi?id=199225

Attachment 386586: Patch

https://bugs.webkit.org/attachment.cgi?id=386586&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 386586
  --> https://bugs.webkit.org/attachment.cgi?id=386586
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386586&action=review

Looks like there are failures in
LayoutTests/http/tests/ssl/applepay/PaymentRequest.https.html

> Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:72
> +	   return Exception { ExistingExceptionError };

Not new: So this is supposed to discard the original exception and replace it
with ExistingExceptionError? Slightly surprised but I guess that’s a modern web
platform design pattern?

> Source/WebCore/Modules/paymentrequest/PaymentHandler.cpp:71
> +    UNUSED_PARAM(document);

Why not sort these the same order as the order they are passed in?

> Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:320
> +    return WTFMove(data);

Not new: JSValue is a simple scalar so there’s no need to do WTFMove.