[webkit-reviews] review granted: [Bug 208393] Delete by val caching does not keep the subscript alive : [Attachment 392026] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Justin Michaud
<justin_michaud at apple.com>'s request for review:
Bug 208393: Delete by val caching does not keep the subscript alive
https://bugs.webkit.org/show_bug.cgi?id=208393

Attachment 392026: Patch

https://bugs.webkit.org/attachment.cgi?id=392026&action=review




--- Comment #6 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 392026
  --> https://bugs.webkit.org/attachment.cgi?id=392026
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392026&action=review

r=me

> Source/JavaScriptCore/runtime/CacheableIdentifier.h:50
>      inline CacheableIdentifier(JSCell* identifier);

Personally I like making this constructor hidden too, and defining
"createFromCell(JSCell*)` factory function instead, but it's up to you :).