[webkit-reviews] review canceled: [Bug 208375] Add an internal setting to enable or disable canvas rendering in the GPU Process : [Attachment 391978] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 28 14:32:06 PST 2020


Wenson Hsieh <wenson_hsieh at apple.com> has canceled Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 208375: Add an internal setting to enable or disable canvas rendering in
the GPU Process
https://bugs.webkit.org/show_bug.cgi?id=208375

Attachment 391978: Patch

https://bugs.webkit.org/attachment.cgi?id=391978&action=review




--- Comment #6 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 391978
  --> https://bugs.webkit.org/attachment.cgi?id=391978
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391978&action=review

>>>>> Source/WebCore/page/Settings.yaml:726
>>>>> +  initial: false
>>>> 
>>>> This doesn't seem like something WebCore should know or care about.
>>> 
>>> Can you please be more explict?
>>> 
>>> The plan is to enable remote rendering for Canvas drawing only. How can we
know outside the HTMLCanvasElement::create() that we want to create an
ImageBuffer for remote drawing?
>>> 
>>> Should we add a function like this one:
>>> 
>>>	HostWindow::createImageBufferForCanvas(...)
>>> 
>>> And call it from HTMLCanvasElement::createImageBuffer()?
>> 
>> Interesting...my understanding was that the GPU Process was not something
WebCore should care about, but that the notion of "remote drawing" was okay
(hence, RemoteAccelerated on RenderingMode).
> 
> I'm with Sam, doesn't seem like we need to infect WebCore with this. Just
hide it behind ChromeClient like everything else (see e.g.:
> 
>     // Allows ports to customize the type of graphics layers created by this
page.
>     virtual GraphicsLayerFactory* graphicsLayerFactory() const { return
nullptr; }
> 
> )

Okay, I see — it seems we should (at the very least) be asking the client layer
for a RenderingMode, then, so it never needs to have a notion of
Remote{Acclerated|Unaccelerated} at all.


More information about the webkit-reviews mailing list